#0: Fix failing TG regression tests #16776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfjchu
requested review from
aliuTT,
tt-asaigal and
omilyutin-tt
as code owners
omilyutin-tt
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
None
Problem description
There are failing TG regression tests. T3000 tests are unaffected. The failures are because
tt::Cluster::instance().number_of_user_devices();should be used instead (which filters out the gateway wormhole devices -- i.e. returns 32, instead of 36).What's changed
Predicate coordinate translation lookup based on:
tt::Cluster::instance().number_of_user_devices()API instead.Checklist